Went through the source of IcedTeaWeb with FindBugs and went over all reported cases of == being used to compare String's. Some usage cases were valid (eg, .equals eventually called, magic String value). I noted one such usage case. The others were changed to .equals calls.

1 files changed, 5 insertions, 5 deletions

diff --git a/plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java b/plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java
index d5edc6f..973a324 100644
--- a/plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java
+++ b/plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java
@@ -41,15 +41,15 @@ public class PluginCallRequestFactory {
 
     public PluginCallRequest getPluginCallRequest(String id, String message, Long reference) {
 
-        if (id == "member") {
+        if ("member".equals(id)) {
             return new GetMemberPluginCallRequest(message, reference);
-        } else if (id == "void") {
+        } else if ("void".equals(id)) {
             return new VoidPluginCallRequest(message, reference);
-        } else if (id == "window") {
+        } else if ("window".equals(id)) {
             return new GetWindowPluginCallRequest(message, reference);
-        } else if (id == "proxyinfo") {
+        } else if ("proxyinfo".equals(id)) {
             return new PluginProxyInfoRequest(message, reference);
-        } else if (id == "cookieinfo") {
+        } else if ("cookieinfo".equals(id)) {
             return new PluginCookieInfoRequest(message, reference);
         } else {
             throw new RuntimeException("Unknown plugin call request type requested from factory");