Launch errors are not being printed to terminal

2012-03-14  Omair Majid  <[email protected]>

    Print exceptions to terminal when running in gui mode too.
    * netx/net/sourceforge/jnlp/AbstractLaunchHandler.java: New file.
    * netx/net/sourceforge/jnlp/DefaultLaunchHandler.java: Extend
    AbstractLaunchHandler.
    (DefaultLaunchHandler): New method.
    (printMessage): Moved to parent class.
    * netx/net/sourceforge/jnlp/GuiLaunchHandler.java: Extend
    AbstractLaunchHandler.
    (GuiLauchHandler): New method.
    (launchError): Print the error too.
    (launchWarning,validationError): Call parent's printMessage.
    * netx/net/sourceforge/jnlp/LaunchException.java: Use standard java
    exception chaining. This removes compatibility with pre-java 1.3 class
    libraries.
    (LaunchException(JNLPFile,Exception,String,String,String,String)): Pass
    cause to parent so exceptions are chanined properly.
    (LaunchException(String,Throwable),LaunchException(Throwable)): Call
    parent's constructor.
    (printStackTrace(PrintStream),printStackTrace(PrintWriter),getCause):
    Removed. Use parent's implementation instead.
    (getCauses): Removed.
    * netx/net/sourceforge/jnlp/LaunchHandler.java
    (validationError): Rename argument to clarify meaing.
    * netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java
    (initialize): Redirect output of all handlers to System.err.
    * plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java
    (PluginAppletSecurityContext): Likewise.
    * tests/netx/unit/net/sourceforge/jnlp/DefaultLaunchHandlerTest.java,
    * tests/netx/unit/net/sourceforge/jnlp/LaunchExceptionTest.java: New
    file. Contains tests.

1 files changed, 10 insertions, 4 deletions

diff --git a/netx/net/sourceforge/jnlp/GuiLaunchHandler.java b/netx/net/sourceforge/jnlp/GuiLaunchHandler.java
index 371d302..7bb8bc1 100644
--- a/netx/net/sourceforge/jnlp/GuiLaunchHandler.java
+++ b/netx/net/sourceforge/jnlp/GuiLaunchHandler.java
@@ -37,6 +37,7 @@ exception statement from your version. */
 
 package net.sourceforge.jnlp;
 
+import java.io.PrintStream;
 import java.lang.reflect.InvocationTargetException;
 import java.net.URL;
 
@@ -51,12 +52,16 @@ import net.sourceforge.jnlp.util.BasicExceptionDialog;
  * A {@link LaunchHandler} that gives feedback to the user using GUI elements
  * including splash screens and exception dialogs.
  */
-public class GuiLaunchHandler implements LaunchHandler {
+public class GuiLaunchHandler extends AbstractLaunchHandler {
 
     private JNLPSplashScreen splashScreen = null;
     private final Object mutex = new Object();
     private UpdatePolicy policy = UpdatePolicy.ALWAYS;
 
+    public GuiLaunchHandler(PrintStream outputStream) {
+        super(outputStream);
+    }
+
     @Override
     public void launchCompleted(ApplicationInstance application) {
         // do nothing
@@ -71,6 +76,7 @@ public class GuiLaunchHandler implements LaunchHandler {
                 BasicExceptionDialog.show(exception);
             }
         });
+        printMessage(exception);
     }
 
     private void closeSplashScreen() {
@@ -141,14 +147,14 @@ public class GuiLaunchHandler implements LaunchHandler {
 
     @Override
     public boolean launchWarning(LaunchException warning) {
-        DefaultLaunchHandler.printMessage(warning);
+        printMessage(warning);
         return true;
     }
 
     @Override
-    public boolean validationError(LaunchException security) {
+    public boolean validationError(LaunchException error) {
         closeSplashScreen();
-        DefaultLaunchHandler.printMessage(security);
+        printMessage(error);
         return true;
     }