From 4094135ed7e7d1f2c22cf944094f7f0daf2cd8e6 Mon Sep 17 00:00:00 2001 From: Chris Robinson Date: Tue, 28 Apr 2020 19:25:58 -0700 Subject: Don't return a bool from the backend start method --- alc/backends/solaris.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'alc/backends/solaris.cpp') diff --git a/alc/backends/solaris.cpp b/alc/backends/solaris.cpp index 6f058a16..8309d442 100644 --- a/alc/backends/solaris.cpp +++ b/alc/backends/solaris.cpp @@ -65,7 +65,7 @@ struct SolarisBackend final : public BackendBase { void open(const ALCchar *name) override; bool reset() override; - bool start() override; + void start() override; void stop() override; int mFd{-1}; @@ -228,19 +228,16 @@ bool SolarisBackend::reset() return true; } -bool SolarisBackend::start() +void SolarisBackend::start() { try { mKillNow.store(false, std::memory_order_release); mThread = std::thread{std::mem_fn(&SolarisBackend::mixerProc), this}; - return true; } catch(std::exception& e) { - ERR("Could not create playback thread: %s\n", e.what()); + throw al::backend_exception{ALC_INVALID_DEVICE, "Failed to start mixing thread: %s", + e.what()}; } - catch(...) { - } - return false; } void SolarisBackend::stop() -- cgit v1.2.3