From 2dc9cf170c08f0b7f35ec46cb17c829888e7392c Mon Sep 17 00:00:00 2001 From: Chris Robinson Date: Sat, 5 Mar 2022 01:14:26 -0800 Subject: Simplify committing EAX properties Based on DirectSound's EAX behavior, committing any EAX property commits *all* deferred property changes, not just the object being changed. So applying EAX changes can be handled in one place. --- al/effects/null.cpp | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) (limited to 'al/effects/null.cpp') diff --git a/al/effects/null.cpp b/al/effects/null.cpp index 5602280b..a0eb2247 100644 --- a/al/effects/null.cpp +++ b/al/effects/null.cpp @@ -106,9 +106,7 @@ class EaxNullEffect final : public: EaxNullEffect(); - // [[nodiscard]] - bool dispatch( - const EaxEaxCall& eax_call) override; + void dispatch(const EaxEaxCall& eax_call) override; // [[nodiscard]] bool apply_deferred() override; @@ -133,16 +131,10 @@ EaxNullEffect::EaxNullEffect() { } -// [[nodiscard]] -bool EaxNullEffect::dispatch( - const EaxEaxCall& eax_call) +void EaxNullEffect::dispatch(const EaxEaxCall& eax_call) { - if (eax_call.get_property_id() != 0) - { + if(eax_call.get_property_id() != 0) throw EaxNullEffectException{"Unsupported property id."}; - } - - return false; } bool EaxNullEffect::apply_deferred() -- cgit v1.2.3