From 2dc9cf170c08f0b7f35ec46cb17c829888e7392c Mon Sep 17 00:00:00 2001 From: Chris Robinson Date: Sat, 5 Mar 2022 01:14:26 -0800 Subject: Simplify committing EAX properties Based on DirectSound's EAX behavior, committing any EAX property commits *all* deferred property changes, not just the object being changed. So applying EAX changes can be handled in one place. --- al/eax_effect.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'al/eax_effect.h') diff --git a/al/eax_effect.h b/al/eax_effect.h index 6de9afcc..45315ca6 100644 --- a/al/eax_effect.h +++ b/al/eax_effect.h @@ -17,11 +17,9 @@ public: const ALenum al_effect_type_; EffectProps al_effect_props_{}; - // Returns "true" if any immediated property was changed. - // [[nodiscard]] - virtual bool dispatch( - const EaxEaxCall& eax_call) = 0; + virtual void dispatch(const EaxEaxCall& eax_call) = 0; + // Returns "true" if any immediated property was changed. // [[nodiscard]] virtual bool apply_deferred() = 0; }; // EaxEffect -- cgit v1.2.3