From 556d92b63555a085b25e32b1cd55afce24edd07a Mon Sep 17 00:00:00 2001
From: Sven Gothel <sgothel@jausoft.com>
Date: Thu, 3 Jul 2014 16:21:36 +0200
Subject: Code Clean-Up based on our Recommended Settings (jogamp-scripting
c47bc86ae2ee268a1f38c5580d11f93d7f8d6e74)
- Change non static accesses to static members using declaring type
- Change indirect accesses to static members to direct accesses (accesses through subtypes)
- Add final modifier to private fields
- Add final modifier to method parameters
- Add final modifier to local variables
- Remove unnecessary casts
- Remove unnecessary '$NON-NLS$' tags
- Remove trailing white spaces on all lines
---
.../com/jogamp/opengl/GLRendererQuirks.java | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
(limited to 'src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java')
diff --git a/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java b/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java
index 9c9f4e3d6..078b48ec2 100644
--- a/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java
+++ b/src/jogl/classes/com/jogamp/opengl/GLRendererQuirks.java
@@ -336,7 +336,7 @@ public class GLRendererQuirks {
* </p>
* @see #areSameStickyDevice(AbstractGraphicsDevice, AbstractGraphicsDevice)
*/
- public static GLRendererQuirks getStickyDeviceQuirks(AbstractGraphicsDevice device) {
+ public static GLRendererQuirks getStickyDeviceQuirks(final AbstractGraphicsDevice device) {
final String key = device.getUniqueID();
final GLRendererQuirks has = stickyDeviceQuirks.get(key);
final GLRendererQuirks res;
@@ -353,7 +353,7 @@ public class GLRendererQuirks {
* Returns true if both devices have the same {@link AbstractGraphicsDevice#getUniqueID()},
* otherwise false.
*/
- public static boolean areSameStickyDevice(AbstractGraphicsDevice device1, AbstractGraphicsDevice device2) {
+ public static boolean areSameStickyDevice(final AbstractGraphicsDevice device1, final AbstractGraphicsDevice device2) {
return device1.getUniqueID() == device2.getUniqueID();
}
@@ -364,7 +364,7 @@ public class GLRendererQuirks {
* </p>
* @see #getStickyDeviceQuirks(AbstractGraphicsDevice)
*/
- public static void addStickyDeviceQuirks(AbstractGraphicsDevice device, int[] quirks, int offset, int len) throws IllegalArgumentException {
+ public static void addStickyDeviceQuirks(final AbstractGraphicsDevice device, final int[] quirks, final int offset, final int len) throws IllegalArgumentException {
final GLRendererQuirks sq = getStickyDeviceQuirks(device);
sq.addQuirks(quirks, offset, len);
}
@@ -375,7 +375,7 @@ public class GLRendererQuirks {
* </p>
* @see #getStickyDeviceQuirks(AbstractGraphicsDevice)
*/
- public static void addStickyDeviceQuirks(AbstractGraphicsDevice device, GLRendererQuirks quirks) throws IllegalArgumentException {
+ public static void addStickyDeviceQuirks(final AbstractGraphicsDevice device, final GLRendererQuirks quirks) throws IllegalArgumentException {
final GLRendererQuirks sq = getStickyDeviceQuirks(device);
sq.addQuirks(quirks);
}
@@ -386,7 +386,7 @@ public class GLRendererQuirks {
* </p>
* @see #getStickyDeviceQuirks(AbstractGraphicsDevice)
*/
- public static boolean existStickyDeviceQuirk(AbstractGraphicsDevice device, int quirk) {
+ public static boolean existStickyDeviceQuirk(final AbstractGraphicsDevice device, final int quirk) {
return getStickyDeviceQuirks(device).exist(quirk);
}
/**
@@ -397,7 +397,7 @@ public class GLRendererQuirks {
* </p>
* @see #getStickyDeviceQuirks(AbstractGraphicsDevice)
*/
- public static void pushStickyDeviceQuirks(AbstractGraphicsDevice device, GLRendererQuirks dest) {
+ public static void pushStickyDeviceQuirks(final AbstractGraphicsDevice device, final GLRendererQuirks dest) {
dest.addQuirks(getStickyDeviceQuirks(device));
}
@@ -413,7 +413,7 @@ public class GLRendererQuirks {
* @param len number of quirks to read from offset within quirks array
* @throws IllegalArgumentException if one of the quirks is out of range
*/
- public GLRendererQuirks(int[] quirks, int offset, int len) throws IllegalArgumentException {
+ public GLRendererQuirks(final int[] quirks, final int offset, final int len) throws IllegalArgumentException {
this();
addQuirks(quirks, offset, len);
}
@@ -424,7 +424,7 @@ public class GLRendererQuirks {
* @param len number of quirks to read from offset within quirks array
* @throws IllegalArgumentException if one of the quirks is out of range
*/
- public final void addQuirks(int[] quirks, int offset, int len) throws IllegalArgumentException {
+ public final void addQuirks(final int[] quirks, final int offset, final int len) throws IllegalArgumentException {
int bitmask = 0;
if( !( 0 <= offset + len && offset + len <= quirks.length ) ) {
throw new IllegalArgumentException("offset and len out of bounds: offset "+offset+", len "+len+", array-len "+quirks.length);
@@ -440,7 +440,7 @@ public class GLRendererQuirks {
/**
* @param quirks valid GLRendererQuirks to be added
*/
- public final void addQuirks(GLRendererQuirks quirks) {
+ public final void addQuirks(final GLRendererQuirks quirks) {
_bitmask |= quirks._bitmask;
}
@@ -449,7 +449,7 @@ public class GLRendererQuirks {
* @return true if quirk exist, otherwise false
* @throws IllegalArgumentException if quirk is out of range
*/
- public final boolean exist(int quirk) throws IllegalArgumentException {
+ public final boolean exist(final int quirk) throws IllegalArgumentException {
validateQuirk(quirk);
return 0 != ( ( 1 << quirk ) & _bitmask );
}
@@ -481,7 +481,7 @@ public class GLRendererQuirks {
* @param quirk the quirk to be validated, i.e. whether it is out of range
* @throws IllegalArgumentException if quirk is out of range
*/
- public static void validateQuirk(int quirk) throws IllegalArgumentException {
+ public static void validateQuirk(final int quirk) throws IllegalArgumentException {
if( !( 0 <= quirk && quirk < COUNT ) ) {
throw new IllegalArgumentException("Quirks must be in range [0.."+COUNT+"[, but quirk: "+quirk);
}
@@ -492,7 +492,7 @@ public class GLRendererQuirks {
* @return the String equivalent of this quirk
* @throws IllegalArgumentException if quirk is out of range
*/
- public static final String toString(int quirk) throws IllegalArgumentException {
+ public static final String toString(final int quirk) throws IllegalArgumentException {
validateQuirk(quirk);
return _names[quirk];
}
--
cgit v1.2.3