From a599b852a041ba3d80b43981589ac1390979dac2 Mon Sep 17 00:00:00 2001 From: Sven Gothel Date: Tue, 4 Jul 2023 11:36:29 +0200 Subject: GlueGen JavaCallback: Revised: Static Java callback dispatcher, dropping native heap, support Struct UserParam ... Implementation now generates a static Java callback dispatcher for each defined SetCallbackFunction, which gets invoked by the generated native static counterpart with all arguments required. The static callback utilizes its own synchronization for thread-safety and fetches the required data set stored at SetCallbackFunction to dispatch the call to the users' CallbackFunction. In case the callback has been removed already, the static callback simply bails out quietly. The native code does not create, release or manage heap memory and therefore is considered safe. +++ Further Struct Type UserParam are now supported including Heterogeneous UserParam mapping (read GlueGen_Mapping.*). +++ Cleaned up code by extracting all JavaCallback emitter code into JavaCallbackEmitter class in one place, leaving JavaMethodbindingEmitter and CMethodbindingEmitter mostly in their original stage (non-convoluted). In this regard, I had to refactor a few function, i.e. moving CMethodbindingEmitter.getJNIMangledArg(..) into JavaType.appendDescriptor(..) and JavaType.appendJNIDescriptor(..) while reusing the toJNIMethodDescriptor(..) conversion. Test4JavaCallback covers and passes all cases. --- .../gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/java/com/jogamp/gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java') diff --git a/src/java/com/jogamp/gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java b/src/java/com/jogamp/gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java index 0d5de1c..b6ed21b 100644 --- a/src/java/com/jogamp/gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java +++ b/src/java/com/jogamp/gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java @@ -91,19 +91,18 @@ public class ProcAddressJavaMethodBindingEmitter extends JavaMethodBindingEmitte } @Override - protected int emitArguments() { - int numEmitted = super.emitArguments(); + protected int appendArguments(final StringBuilder buf) { + int numEmitted = super.appendArguments(buf); if (callThroughProcAddress) { if (changeNameAndArguments) { if (numEmitted > 0) { - unit.emit(", "); + buf.append(", "); } - unit.emit("long procAddress"); + buf.append("long procAddress"); ++numEmitted; } } - return numEmitted; } -- cgit v1.2.3