From 2deb5e47d1f72f211961289e6fa92ae6c89184fb Mon Sep 17 00:00:00 2001 From: Chris Robinson Date: Tue, 21 Apr 2020 23:58:53 -0700 Subject: Avoid an unnecessary out parameter --- alc/effects/echo.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'alc/effects/echo.cpp') diff --git a/alc/effects/echo.cpp b/alc/effects/echo.cpp index e14dc5cb..b53f4f30 100644 --- a/alc/effects/echo.cpp +++ b/alc/effects/echo.cpp @@ -99,13 +99,12 @@ void EchoState::update(const ALCcontext *context, const ALeffectslot *slot, cons /* Convert echo spread (where 0 = center, +/-1 = sides) to angle. */ const float angle{std::asin(props->Echo.Spread)}; - float coeffs[2][MAX_AMBI_CHANNELS]; - CalcAngleCoeffs(-angle, 0.0f, 0.0f, coeffs[0]); - CalcAngleCoeffs( angle, 0.0f, 0.0f, coeffs[1]); + const auto coeffs0 = CalcAngleCoeffs(-angle, 0.0f, 0.0f); + const auto coeffs1 = CalcAngleCoeffs( angle, 0.0f, 0.0f); mOutTarget = target.Main->Buffer; - ComputePanGains(target.Main, coeffs[0], slot->Params.Gain, mGains[0].Target); - ComputePanGains(target.Main, coeffs[1], slot->Params.Gain, mGains[1].Target); + ComputePanGains(target.Main, coeffs0.data(), slot->Params.Gain, mGains[0].Target); + ComputePanGains(target.Main, coeffs1.data(), slot->Params.Gain, mGains[1].Target); } void EchoState::process(const size_t samplesToDo, const al::span samplesIn, const al::span samplesOut) -- cgit v1.2.3