From 6944d3485ad005c6cd69a3122479f1fbaef26dfc Mon Sep 17 00:00:00 2001 From: Sven Gothel Date: Tue, 18 Jun 2013 01:44:39 +0200 Subject: GLDynamicLibraryBundleInfo.shallLinkGlobal(): Defaults to 'true' now, allowing to remove specialized values. - Windows always used global - The OpenGL library is always available by all processes system wide. - Tested on OSX (was using local, previously). --- .../jogamp/opengl/GLDynamicLibraryBundleInfo.java | 20 +++++++++++++++----- .../egl/DesktopES2DynamicLibraryBundleInfo.java | 10 ---------- .../opengl/egl/EGLDynamicLibraryBundleInfo.java | 14 ++++---------- .../x11/glx/X11GLXDynamicLibraryBundleInfo.java | 9 --------- 4 files changed, 19 insertions(+), 34 deletions(-) (limited to 'src/jogl/classes/jogamp/opengl') diff --git a/src/jogl/classes/jogamp/opengl/GLDynamicLibraryBundleInfo.java b/src/jogl/classes/jogamp/opengl/GLDynamicLibraryBundleInfo.java index 4c82fc2b3..a2e3b3175 100644 --- a/src/jogl/classes/jogamp/opengl/GLDynamicLibraryBundleInfo.java +++ b/src/jogl/classes/jogamp/opengl/GLDynamicLibraryBundleInfo.java @@ -36,11 +36,21 @@ public abstract class GLDynamicLibraryBundleInfo implements DynamicLibraryBundle protected GLDynamicLibraryBundleInfo() { } - /** default **/ - @Override - public boolean shallLinkGlobal() { return false; } - - /** default **/ + /** + * Returns true, + * since we might load a desktop GL library and allow symbol access to subsequent libs. + *

+ * This respects old DRI requirements: + *

+     * http://dri.sourceforge.net/doc/DRIuserguide.html
+     * 
+ *

+ */ + public boolean shallLinkGlobal() { return true; } + + /** + * Default value: false. + */ @Override public boolean shallLookupGlobal() { return false; } diff --git a/src/jogl/classes/jogamp/opengl/egl/DesktopES2DynamicLibraryBundleInfo.java b/src/jogl/classes/jogamp/opengl/egl/DesktopES2DynamicLibraryBundleInfo.java index cddd142e9..771d16d46 100644 --- a/src/jogl/classes/jogamp/opengl/egl/DesktopES2DynamicLibraryBundleInfo.java +++ b/src/jogl/classes/jogamp/opengl/egl/DesktopES2DynamicLibraryBundleInfo.java @@ -47,16 +47,6 @@ public class DesktopES2DynamicLibraryBundleInfo extends GLDynamicLibraryBundleIn super(); } - /** - * Might be a desktop GL library, and might need to allow symbol access to subsequent libs. - * - * This respects old DRI requirements:
- *
-     * http://dri.sourceforge.net/doc/DRIuserguide.html
-     * 
- */ - public boolean shallLinkGlobal() { return true; } - public final List getToolGetProcAddressFuncNameList() { List res = new ArrayList(); res.add("eglGetProcAddress"); diff --git a/src/jogl/classes/jogamp/opengl/egl/EGLDynamicLibraryBundleInfo.java b/src/jogl/classes/jogamp/opengl/egl/EGLDynamicLibraryBundleInfo.java index fe9d7573d..26b199ea2 100644 --- a/src/jogl/classes/jogamp/opengl/egl/EGLDynamicLibraryBundleInfo.java +++ b/src/jogl/classes/jogamp/opengl/egl/EGLDynamicLibraryBundleInfo.java @@ -29,6 +29,7 @@ package jogamp.opengl.egl; import com.jogamp.common.os.AndroidVersion; +import com.jogamp.common.os.Platform; import java.util.*; @@ -52,19 +53,12 @@ public abstract class EGLDynamicLibraryBundleInfo extends GLDynamicLibraryBundle } /** - * Might be a desktop GL library, and might need to allow symbol access to subsequent libs. - * - * This respects old DRI requirements:
- *
-     * http://dri.sourceforge.net/doc/DRIuserguide.html
-     * 
+ * Returns true on Android, + * and false otherwise. */ - @Override - public boolean shallLinkGlobal() { return true; } - @Override public boolean shallLookupGlobal() { - if ( AndroidVersion.isAvailable ) { + if ( Platform.OSType.ANDROID == Platform.OS_TYPE ) { // Android requires global symbol lookup return true; } diff --git a/src/jogl/classes/jogamp/opengl/x11/glx/X11GLXDynamicLibraryBundleInfo.java b/src/jogl/classes/jogamp/opengl/x11/glx/X11GLXDynamicLibraryBundleInfo.java index 108c157a8..6083f209c 100644 --- a/src/jogl/classes/jogamp/opengl/x11/glx/X11GLXDynamicLibraryBundleInfo.java +++ b/src/jogl/classes/jogamp/opengl/x11/glx/X11GLXDynamicLibraryBundleInfo.java @@ -60,15 +60,6 @@ public class X11GLXDynamicLibraryBundleInfo extends DesktopGLDynamicLibraryBundl return libsList; } - /** - * This respects old DRI requirements:
- *
-     * http://dri.sourceforge.net/doc/DRIuserguide.html
-     * 
- */ - @Override - public boolean shallLinkGlobal() { return true; } - @Override public final List getToolGetProcAddressFuncNameList() { List res = new ArrayList(); -- cgit v1.2.3