From 61d365bd7c352262bff711b3954731e7928c203f Mon Sep 17 00:00:00 2001 From: Michael Bien Date: Sun, 27 Feb 2011 02:07:37 +0100 Subject: code review using findbugs keyset iterations, typos, @Override, synchronization, varargs --- src/com/jogamp/opencl/CLProgram.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/com/jogamp/opencl/CLProgram.java') diff --git a/src/com/jogamp/opencl/CLProgram.java b/src/com/jogamp/opencl/CLProgram.java index 3cb63003..544df117 100644 --- a/src/com/jogamp/opencl/CLProgram.java +++ b/src/com/jogamp/opencl/CLProgram.java @@ -96,10 +96,10 @@ public class CLProgram extends CLObject implements CLResource { PointerBuffer lengths = PointerBuffer.allocateDirect(binaries.size()); int i = 0; - Set keys = binaries.keySet(); - for (CLDevice device : keys) { + for (Map.Entry entry : binaries.entrySet()) { - byte[] bytes = binaries.get(device); + byte[] bytes = entry.getValue(); + CLDevice device = entry.getKey(); devices.put(device.ID); lengths.put(bytes.length); @@ -337,6 +337,7 @@ public class CLProgram extends CLObject implements CLResource { BuildProgramCallback callback = null; if(listener != null) { callback = new BuildProgramCallback() { + @Override public void buildFinished(long cl_program) { buildLock.unlock(); listener.buildFinished(CLProgram.this); @@ -446,6 +447,7 @@ public class CLProgram extends CLObject implements CLResource { /** * Releases this program with its kernels. */ + @Override public void release() { releaseKernels(); -- cgit v1.2.3