From b42384fe344b0af2a54eb00735f7d59b6ba1ab6e Mon Sep 17 00:00:00 2001
From: Adam Domurad <adomurad@redhat.com>
Date: Thu, 17 May 2012 14:14:03 -0400
Subject: Went through the source of IcedTeaWeb with FindBugs and went over all
reported cases of == being used to compare String's. Some usage cases were
valid (eg, .equals eventually called, magic String value). I noted one such
usage case. The others were changed to .equals calls.
---
plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(limited to 'plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java')
diff --git a/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java b/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
index 2cea3da..e9b71c2 100644
--- a/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
+++ b/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
@@ -50,7 +50,7 @@ public class GetMemberPluginCallRequest extends PluginCallRequest {
String[] args = message.split(" ");
// FIXME: Is it even possible to distinguish between null and void
// here?
- if (args[3] != "null" && args[3] != "void")
+ if (!"null".equals(args[3]) && !"void".equals(args[3]))
object = AppletSecurityContextManager.getSecurityContext(0).getObject(Integer.parseInt(args[3]));
setDone(true);
}
--
cgit v1.2.3