From 0d09c09346dff6c51456306018e6fc64b2993ecb Mon Sep 17 00:00:00 2001 From: Harvey Harrison Date: Fri, 24 Aug 2012 16:08:33 -0700 Subject: j3dcore: remove the displayID from screen as all remaining pipelines ignore it Signed-off-by: Harvey Harrison --- src/classes/share/javax/media/j3d/Canvas3D.java | 52 +++++++++++----------- .../share/javax/media/j3d/JoglPipeline.java | 22 ++++----- .../share/javax/media/j3d/MasterControl.java | 2 +- .../share/javax/media/j3d/NoopPipeline.java | 19 +++----- src/classes/share/javax/media/j3d/Pipeline.java | 17 ++++--- src/classes/share/javax/media/j3d/Renderer.java | 36 ++++++--------- src/classes/share/javax/media/j3d/Screen3D.java | 7 +-- 7 files changed, 64 insertions(+), 91 deletions(-) (limited to 'src') diff --git a/src/classes/share/javax/media/j3d/Canvas3D.java b/src/classes/share/javax/media/j3d/Canvas3D.java index c09235d..1ffd891 100644 --- a/src/classes/share/javax/media/j3d/Canvas3D.java +++ b/src/classes/share/javax/media/j3d/Canvas3D.java @@ -2382,7 +2382,7 @@ ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList 0); } - // Methods to get native WS display and screen - long getDisplay() { - if (VERBOSE) System.err.println("JoglPipeline.getDisplay()"); - return 0L; // Dummy method in JOGL - } - private boolean checkedForGetScreenMethod = false; private Method getScreenMethod = null; int getScreen(final GraphicsDevice graphicsDevice) { diff --git a/src/classes/share/javax/media/j3d/MasterControl.java b/src/classes/share/javax/media/j3d/MasterControl.java index 654fdd6..b4ea7fd 100644 --- a/src/classes/share/javax/media/j3d/MasterControl.java +++ b/src/classes/share/javax/media/j3d/MasterControl.java @@ -2860,7 +2860,7 @@ private static String getProperty(final String prop) { createMessage.view = null; createMessage.args[0] = c; // Fix for issue 340: send display, drawable & ctx in msg - createMessage.args[1] = new Long(c.screen.display); + createMessage.args[1] = Long.valueOf(0L); createMessage.args[2] = c.drawable; createMessage.args[3] = c.ctx; rdr.rendererStructure.addMessage(createMessage); diff --git a/src/classes/share/javax/media/j3d/NoopPipeline.java b/src/classes/share/javax/media/j3d/NoopPipeline.java index 63a3b3d..21348f3 100644 --- a/src/classes/share/javax/media/j3d/NoopPipeline.java +++ b/src/classes/share/javax/media/j3d/NoopPipeline.java @@ -951,22 +951,22 @@ class NoopPipeline extends Pipeline { // // This is the native method for creating the underlying graphics context. - Context createNewContext(Canvas3D cv, long display, Drawable drawable, + Context createNewContext(Canvas3D cv, Drawable drawable, Context shareCtx, boolean isSharedCtx, boolean offScreen) { return new NoopContext(); } - void createQueryContext(Canvas3D cv, long display, Drawable drawable, + void createQueryContext(Canvas3D cv, Drawable drawable, boolean offScreen, int width, int height) { } // This is the native for creating offscreen buffer - Drawable createOffScreenBuffer(Canvas3D cv, Context ctx, long display, int width, int height) { + Drawable createOffScreenBuffer(Canvas3D cv, Context ctx, int width, int height) { return null; } - void destroyOffScreenBuffer(Canvas3D cv, Context ctx, long display, Drawable drawable) { + void destroyOffScreenBuffer(Canvas3D cv, Context ctx, Drawable drawable) { } // This is the native for reading the image from the offscreen buffer @@ -974,7 +974,7 @@ class NoopPipeline extends Pipeline { } // The native method for swapBuffers - int swapBuffers(Canvas3D cv, Context ctx, long dpy, Drawable drawable) { + int swapBuffers(Canvas3D cv, Context ctx, Drawable drawable) { return 0; } @@ -982,7 +982,7 @@ class NoopPipeline extends Pipeline { void updateMaterialColor(Context ctx, float r, float g, float b, float a) { } - void destroyContext(long display, Drawable drawable, Context ctx) { + void destroyContext(Drawable drawable, Context ctx) { } // This is the native method for doing accumulation. @@ -1123,7 +1123,7 @@ class NoopPipeline extends Pipeline { } // The native method that sets this ctx to be the current one - boolean useCtx(Context ctx, long display, Drawable drawable) { + boolean useCtx(Context ctx, Drawable drawable) { return true; } @@ -1263,11 +1263,6 @@ class NoopPipeline extends Pipeline { return false; } - // Methods to get native WS display and screen - long getDisplay() { - return 0L; - } - int getScreen(GraphicsDevice graphicsDevice) { return 0; } diff --git a/src/classes/share/javax/media/j3d/Pipeline.java b/src/classes/share/javax/media/j3d/Pipeline.java index 779575f..9c9e5ea 100644 --- a/src/classes/share/javax/media/j3d/Pipeline.java +++ b/src/classes/share/javax/media/j3d/Pipeline.java @@ -964,28 +964,28 @@ public Pipeline run() { // // This is the native method for creating the underlying graphics context. - abstract Context createNewContext(Canvas3D cv, long display, Drawable drawable, + abstract Context createNewContext(Canvas3D cv, Drawable drawable, Context shareCtx, boolean isSharedCtx, boolean offScreen); - abstract void createQueryContext(Canvas3D cv, long display, Drawable drawable, + abstract void createQueryContext(Canvas3D cv, Drawable drawable, boolean offScreen, int width, int height); // This is the native for creating offscreen buffer - abstract Drawable createOffScreenBuffer(Canvas3D cv, Context ctx, long display, int width, int height); + abstract Drawable createOffScreenBuffer(Canvas3D cv, Context ctx, int width, int height); - abstract void destroyOffScreenBuffer(Canvas3D cv, Context ctx, long display, Drawable drawable); + abstract void destroyOffScreenBuffer(Canvas3D cv, Context ctx, Drawable drawable); // This is the native for reading the image from the offscreen buffer abstract void readOffScreenBuffer(Canvas3D cv, Context ctx, int format, int type, Object data, int width, int height); // The native method for swapBuffers - abstract int swapBuffers(Canvas3D cv, Context ctx, long dpy, Drawable drawable); + abstract int swapBuffers(Canvas3D cv, Context ctx, Drawable drawable); // native method for setting Material when no material is present abstract void updateMaterialColor(Context ctx, float r, float g, float b, float a); - abstract void destroyContext(long display, Drawable drawable, Context ctx); + abstract void destroyContext(Drawable drawable, Context ctx); // This is the native method for doing accumulation. abstract void accum(Context ctx, float value); @@ -1092,11 +1092,11 @@ public Pipeline run() { abstract void syncRender(Context ctx, boolean wait); // The native method that sets this ctx to be the current one - abstract boolean useCtx(Context ctx, long display, Drawable drawable); + abstract boolean useCtx(Context ctx, Drawable drawable); // Optionally release the context. A pipeline may override this and // returns true if the context was released. - boolean releaseCtx(Context ctx, long dpy) { + boolean releaseCtx(Context ctx) { return false; } @@ -1183,7 +1183,6 @@ public Pipeline run() { abstract boolean hasSceneAntialiasingAccum(Canvas3D cv); // Methods to get native WS display and screen - abstract long getDisplay(); abstract int getScreen(GraphicsDevice graphicsDevice); diff --git a/src/classes/share/javax/media/j3d/Renderer.java b/src/classes/share/javax/media/j3d/Renderer.java index 5cf89d4..a5077df 100644 --- a/src/classes/share/javax/media/j3d/Renderer.java +++ b/src/classes/share/javax/media/j3d/Renderer.java @@ -99,7 +99,6 @@ class Renderer extends J3dThread { long sharedCtxTimeStamp = 0; // display and drawable, used to free shared context - private long sharedCtxDisplay = 0; private Drawable sharedCtxDrawable = null; /** @@ -258,7 +257,6 @@ ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList textureIDResourceTable = new ArrayList