From 9a040a3b9c72a307e3f19078483ede534f289bd0 Mon Sep 17 00:00:00 2001 From: Harvey Harrison Date: Tue, 9 Oct 2012 23:35:31 -0700 Subject: j3dcore: annotate the geometryList in Shape3DRetained Signed-off-by: Harvey Harrison --- .../share/javax/media/j3d/CompileState.java | 16 +-- src/classes/share/javax/media/j3d/PickInfo.java | 2 +- .../javax/media/j3d/Shape3DCompileRetained.java | 2 +- .../share/javax/media/j3d/Shape3DRetained.java | 122 ++++++++++----------- .../share/javax/media/j3d/Text3DRetained.java | 9 +- 5 files changed, 75 insertions(+), 76 deletions(-) (limited to 'src/classes') diff --git a/src/classes/share/javax/media/j3d/CompileState.java b/src/classes/share/javax/media/j3d/CompileState.java index cfe68a8..fdf777e 100644 --- a/src/classes/share/javax/media/j3d/CompileState.java +++ b/src/classes/share/javax/media/j3d/CompileState.java @@ -139,7 +139,7 @@ AppearanceRetained getAppearance(AppearanceRetained app) { GeometryRetained geometry = null; int i = 0; while (geometry == null && i < shape.geometryList.size()) { - geometry = (GeometryRetained) shape.geometryList.get(i); + geometry = shape.geometryList.get(i); i++; } if (shape.parent instanceof GroupRetained && ((GroupRetained)shape.parent).isStaticChildren() && geometry.geoType < GeometryArrayRetained.GEO_TYPE_RASTER) { @@ -193,7 +193,7 @@ AppearanceRetained getAppearance(AppearanceRetained app) { num = 0; // Get the first non-null geometry while (firstGeo == null && num < shapes[i].geometryList.size()) { - firstGeo = (GeometryRetained) shapes[i].geometryList.get(num); + firstGeo = shapes[i].geometryList.get(num); num++; } @@ -214,7 +214,7 @@ AppearanceRetained getAppearance(AppearanceRetained app) { num = 0; // Get the first non-null geometry while (firstGeo == null && num < shapes[j].geometryList.size()) { - firstGeo = (GeometryRetained) shapes[j].geometryList.get(num); + firstGeo = shapes[j].geometryList.get(num); num++; } @@ -262,11 +262,11 @@ AppearanceRetained getAppearance(AppearanceRetained app) { System.err.println("Dest is "+ parentGroup); System.err.println("Compile Shape "+mergeShape); System.err.println(mergeShape.geometryList.size()+" geoemtryList"); - for (int j = 0; j < mergeShape.geometryList.size(); j++) { - GeometryRetained geo = ((GeometryRetained)mergeShape.geometryList.get(j)); - if (geo != null) - System.err.println("\t Geo_type = "+geo.geoType); - } + for (int j = 0; j < mergeShape.geometryList.size(); j++) { + GeometryRetained geo = mergeShape.geometryList.get(j); + if (geo != null) + System.err.println("\t Geo_type = " + geo.geoType); + } System.err.println(numMerge+" Shapes were merged "); for (int j = 0; j < numMerge; j++) { diff --git a/src/classes/share/javax/media/j3d/PickInfo.java b/src/classes/share/javax/media/j3d/PickInfo.java index 4c54133..610179c 100644 --- a/src/classes/share/javax/media/j3d/PickInfo.java +++ b/src/classes/share/javax/media/j3d/PickInfo.java @@ -634,7 +634,7 @@ public class PickInfo extends Object { Shape3DRetained s3dR = (Shape3DRetained) srcNode; GeometryRetained geomR = null; for(int cnt=0; cnt sList = new ArrayList(); for (j = 0; j < shape.geometryList.size(); j++) { - GeometryRetained g = (GeometryRetained)shape.geometryList.get(j); + GeometryRetained g = shape.geometryList.get(j); if (g != null) sList.add((Geometry)g.source); else diff --git a/src/classes/share/javax/media/j3d/Shape3DRetained.java b/src/classes/share/javax/media/j3d/Shape3DRetained.java index becb31d..bfb18fb 100644 --- a/src/classes/share/javax/media/j3d/Shape3DRetained.java +++ b/src/classes/share/javax/media/j3d/Shape3DRetained.java @@ -55,10 +55,10 @@ class Shape3DRetained extends LeafRetained { */ AppearanceRetained appearance = null; - /** - * The arraylist of geometry component of the shape node. - */ - ArrayList geometryList = null; +/** + * The arraylist of geometry component of the shape node. + */ +ArrayList geometryList = null; /** * A 2D storage of all geometry atoms associated with this shape node. @@ -189,7 +189,7 @@ class Shape3DRetained extends LeafRetained { localBounds = new BoundingBox((BoundingBox) null); mirrorShape3DLock = new MRSWLock(); - geometryList = new ArrayList(1); + geometryList = new ArrayList(1); geometryList.add(null); } @@ -329,7 +329,7 @@ class Shape3DRetained extends LeafRetained { if (((Shape3D)this.source).isLive()) { - oldGeom = (GeometryRetained) (geometryList.get(index)); + oldGeom = geometryList.get(index); if (oldGeom != null) { oldGeom.clearLive(refCount); for (i=0; i geomList = new Vector(geometryList.size()); - for(int i=0; i 1) { return false; @@ -1475,7 +1475,7 @@ class Shape3DRetained extends LeafRetained { } for (int i = 0; i < geometryList.size(); i++) { - GeometryRetained geo = (GeometryRetained)geometryList.get(i); + GeometryRetained geo = geometryList.get(i); if (geo != null) geo.compile(compState); } @@ -1528,7 +1528,7 @@ class Shape3DRetained extends LeafRetained { // Get the first geometry that is non-null while (geometry == null && index < geometryList.size()) { - geometry = (GeometryRetained) geometryList.get(index); + geometry = geometryList.get(index); index++; } @@ -1539,7 +1539,7 @@ class Shape3DRetained extends LeafRetained { GeometryArrayRetained firstGeo = (GeometryArrayRetained) geometry; for(i=index; (i gaList = otherShape.geometryList; int gaSize = gaList.size(); Transform3D otherLocalToVworld = otherShape.getCurrentLocalToVworld(); Transform3D thisLocalToVworld = getCurrentLocalToVworld(); @@ -2108,10 +2108,10 @@ class Shape3DRetained extends LeafRetained { } for (int i=geometryList.size()-1; i >=0; i--) { - geom1 = (GeometryRetained) geometryList.get(i); + geom1 = geometryList.get(i); if (geom1 != null) { for (int j=gaSize-1; j >=0; j--) { - geom2 = (GeometryRetained) gaList.get(j); + geom2 = gaList.get(j); if ((geom2 != null) && geom1.intersect(thisLocalToVworld, otherLocalToVworld, geom2)) { @@ -2136,7 +2136,7 @@ class Shape3DRetained extends LeafRetained { } for (int i=geometryList.size() - 1; i >=0; i--) { - geometry = (GeometryRetained) geometryList.get(i); + geometry = geometryList.get(i); if ((geometry != null) && geometry.intersect(thisLocalToVworld, targetBound)) { return true; @@ -2190,7 +2190,7 @@ class Shape3DRetained extends LeafRetained { appearanceOverrideEnable = morph.appearanceOverrideEnable; // mga is the final geometry we're interested. - geometryList = new ArrayList(1); + geometryList = new ArrayList(1); geometryList.add((GeometryArrayRetained)morph.morphedGeometryArray.retained); GeometryAtom gAtom = new GeometryAtom(); @@ -2200,7 +2200,7 @@ class Shape3DRetained extends LeafRetained { gAtom.visible = morph.visible; gAtom.source = this; - geometry = (GeometryRetained) geometryList.get(0); + geometry = geometryList.get(0); if(geometry ==null) { gAtom.geometryArray[0] = null; @@ -2233,7 +2233,7 @@ class Shape3DRetained extends LeafRetained { oldGA = Shape3DRetained.getGeomAtom(ms); - ms.geometryList = new ArrayList(1); + ms.geometryList = new ArrayList(1); ms.geometryList.add((GeometryArrayRetained)geometry.retained); newGA = new GeometryAtom(); @@ -2496,7 +2496,7 @@ final static ArrayList> getGeomAtomsList(ArrayList userL bounds.setLower( 1.0, 1.0, 1.0); bounds.setUpper(-1.0,-1.0,-1.0); for(int i=0; i> getGeomAtomsList(ArrayList userL } GeometryAtom gAtom = new GeometryAtom(); for(gaCnt=0; gaCnt> getGeomAtomsList(ArrayList userL (geometry.geoType == GeometryRetained.GEO_TYPE_TEXT3D)) { for(gaCnt = 0; gaCnt> getGeomAtomsList(ArrayList userL for(gaCnt = 0; gaCnt> getGeomAtomsList(ArrayList userL if (geometry != null) { for (int i=geometryList.size()-1; i >= 0; i--) { - GeometryRetained geomRetained = (GeometryRetained) geometryList.get(i); + GeometryRetained geomRetained = geometryList.get(i); if ((geomRetained != null) && (index != i)) { // this geometry will replace // current one so there is no need to check @@ -2710,7 +2710,7 @@ final static ArrayList> getGeomAtomsList(ArrayList userL if (((Shape3D)this.source).isLive()) { for(int index = n-1; index >= 0; index--) { - oldGeom = (GeometryRetained) (geometryList.get(index)); + oldGeom = geometryList.get(index); if (oldGeom != null) { oldGeom.clearLive(refCount); oldGeom.decRefCnt(); @@ -2724,7 +2724,7 @@ final static ArrayList> getGeomAtomsList(ArrayList userL sendDataChangedMessage(null); } else { for(int index = n-1; index >= 0; index--) { - oldGeom = (GeometryRetained) (geometryList.get(index)); + oldGeom = geometryList.get(index); if (oldGeom != null) { oldGeom.decRefCnt(); } diff --git a/src/classes/share/javax/media/j3d/Text3DRetained.java b/src/classes/share/javax/media/j3d/Text3DRetained.java index 7f37446..03416bc 100644 --- a/src/classes/share/javax/media/j3d/Text3DRetained.java +++ b/src/classes/share/javax/media/j3d/Text3DRetained.java @@ -498,8 +498,7 @@ class Text3DRetained extends GeometryRetained { int geometryCnt = 0; for(k = 0; k